Skip to content

feature: Allow multiple backend processes with urls config #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

nickpalmer
Copy link

@nickpalmer nickpalmer commented Nov 19, 2020

Fixes #349

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2020

CLA assistant check
All committers have signed the CLA.

nickpalmer and others added 3 commits November 19, 2020 10:18
I found while setting this up that more logs were helpful to know if I had something misconfigured
@bahmutov bahmutov self-requested a review November 23, 2020 15:44
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to have an issue for this PR with description, and an example in the examples folder to validate it is working.

Also, I think a better / simpler solution would be to just allow the url parameter to accept multiple URLs comma-separated

{
  "env": {
    "codeCoverage": {
      "url": "http://localhost:3000/__coverage__, http://localhost:8080/__coverage__"
    }
  }
}

@nickpalmer
Copy link
Author

The only issue with using commas I can think of is if somebody needs a comma in the URI for some weird reason. I will try to find time to add an example soon.

@jennifer-shehane
Copy link
Member

@nickpalmer Do you still have time to address the changes requested in this PR? We will have to close this PR due to inactivity otherwise.

@nickpalmer
Copy link
Author

Sorry, super busy lately, but I will update the PR with review feedback next week.

@nickpalmer nickpalmer requested a review from bahmutov March 18, 2021 22:21
Husky and a precommit hook would be nice for contributors not used to your style
@truxiced
Copy link

truxiced commented Apr 9, 2021

This is a nice feature, would love to have it in our project.
Is this far out from a release ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple backend processes with urls config
5 participants