-
Notifications
You must be signed in to change notification settings - Fork 110
feature: Allow multiple backend processes with urls config #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I found while setting this up that more logs were helpful to know if I had something misconfigured
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to have an issue for this PR with description, and an example in the examples folder to validate it is working.
Also, I think a better / simpler solution would be to just allow the url
parameter to accept multiple URLs comma-separated
{
"env": {
"codeCoverage": {
"url": "http://localhost:3000/__coverage__, http://localhost:8080/__coverage__"
}
}
}
The only issue with using commas I can think of is if somebody needs a comma in the URI for some weird reason. I will try to find time to add an example soon. |
@nickpalmer Do you still have time to address the changes requested in this PR? We will have to close this PR due to inactivity otherwise. |
Sorry, super busy lately, but I will update the PR with review feedback next week. |
Husky and a precommit hook would be nice for contributors not used to your style
This is a nice feature, would love to have it in our project. |
Fixes #349